add pyproject.toml to ensure pip builds have Cython and numpy#47
Open
dmeliza wants to merge 20 commits intomariomulansky:masterfrom
Open
add pyproject.toml to ensure pip builds have Cython and numpy#47dmeliza wants to merge 20 commits intomariomulansky:masterfrom
dmeliza wants to merge 20 commits intomariomulansky:masterfrom
Conversation
Contributor
Author
|
Bumping this pull request to see if it can be merged. We are using poetry to manage dependencies and so we currently have to build our own wheels to use pyspike. |
…won't merge our PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pip install pyspikewill often fail if Cython is not already in the environment because the C-code stored in the source tree may not work with newer versions of python. Adding apyproject.tomlfile will enable the new PEP517 build system, which can ensure particular packages are present during building.